Skip to content

Conversation

@kyteinsky
Copy link
Contributor

@kyteinsky kyteinsky commented Jul 24, 2025

Changes:

  1. move max output tokens and use_max_completion_tokens_param to the text generation field below the max input tokens field so the settings are better placed
  2. rename "Max new tokens" to "Max output tokens"
  3. wrap checkboxes in <div class="line"> for better spacing
  4. add a info note card for quota usage and the meaning of the "0" value
  5. sanitize quotas in the frontend and improved validation in the backend


@kyteinsky kyteinsky requested review from edward-ly and julien-nc July 24, 2025 13:23
@julien-nc
Copy link
Member

@kyteinsky Could you make a list of short descriptions of the changes you made? What's the style change? What are the quota fixes? It would make it easier to read your changeset.

@kyteinsky
Copy link
Contributor Author

sorry about that, updated the PR description.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the description

@kyteinsky kyteinsky requested a review from edward-ly July 25, 2025 14:33
@kyteinsky kyteinsky merged commit 4755bbc into main Jul 29, 2025
29 checks passed
@kyteinsky kyteinsky deleted the fix/style-quota branch July 29, 2025 13:48
@kyteinsky kyteinsky mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants