Skip to content

feat: add config for disabling the quota webui #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukasdotcom wants to merge 1 commit into from
Closed

feat: add config for disabling the quota webui #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/Service/OpenAiSettingsService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ public function setAdminConfig(array $adminConfig): void {
}
}

$quotaDisabled = $this->config->getSystemValue('integration_openai.disable_webui_quota', false);
// Validation of the input values is done in the individual setters
if (isset($adminConfig['request_timeout'])) {
$this->setRequestTimeout($adminConfig['request_timeout']);
Expand Down Expand Up @@ -722,10 +723,10 @@ public function setAdminConfig(array $adminConfig): void {
if (isset($adminConfig['llm_extra_params'])) {
$this->setLlmExtraParams($adminConfig['llm_extra_params']);
}
if (isset($adminConfig['quota_period'])) {
if (isset($adminConfig['quota_period']) && !$quotaDisabled) {
$this->setQuotaPeriod($adminConfig['quota_period']);
}
if (isset($adminConfig['quotas'])) {
if (isset($adminConfig['quotas']) && !$quotaDisabled) {
$this->setQuotas($adminConfig['quotas']);
}
if (isset($adminConfig['use_max_completion_tokens_param'])) {
Expand Down
3 changes: 3 additions & 0 deletions lib/Settings/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@
use OCP\App\IAppManager;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\AppFramework\Services\IInitialState;
use OCP\IConfig;
use OCP\Settings\ISettings;

class Admin implements ISettings {
public function __construct(
private IInitialState $initialStateService,
private OpenAiSettingsService $openAiSettingsService,
private IAppManager $appManager,
private IConfig $config,
) {
}

Expand All @@ -31,6 +33,7 @@ public function getForm(): TemplateResponse {
$adminConfig['basic_password'] = $adminConfig['basic_password'] === '' ? '' : 'dummyPassword';
$isAssistantEnabled = $this->appManager->isEnabledForUser('assistant');
$adminConfig['assistant_enabled'] = $isAssistantEnabled;
$adminConfig['disable_webui_quota'] = $this->config->getSystemValue('integration_openai.disable_webui_quota', false);
$this->initialStateService->provideInitialState('admin-config', $adminConfig);
return new TemplateResponse(Application::APP_ID, 'adminSettings');
}
Expand Down
5 changes: 5 additions & 0 deletions src/components/AdminSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,9 @@
<h2>
{{ t('integration_openai', 'Usage limits') }}
</h2>
<NcNoteCard v-if="state.disable_webui_quota" type="warning">
{{ t('integration_openai', 'The webui for quota enforcement is disabled in the config.') }}
</NcNoteCard>
<div class="line">
<!--Time period in days for the token usage-->
<NcInputField
Expand All @@ -507,6 +510,7 @@
type="number"
:label="t('integration_openai', 'Quota enforcement time period (days)')"
:show-trailing-button="!!state.quota_period"
:disabled="state.disable_webui_quota"
@update:model-value="onInput()"
@trailing-button-click="state.quota_period = '' ; onInput()">
<template #trailing-button-icon>
Expand Down Expand Up @@ -545,6 +549,7 @@
v-model.number="state.quotas[index]"
:title="t('integration_openai', 'A per-user limit for usage of this API type (0 for unlimited)')"
type="number"
:disabled="state.disable_webui_quota"
@input="onInput()">
<span v-if="quotaInfo !== null" class="text-cell">
{{ quotaInfo[index].unit }}
Expand Down
Loading