Skip to content

fix(TextToImageProvider): Use userFacingErrorMessages #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 1 commit into from
Jan 13, 2026
Merged

fix(TextToImageProvider): Use userFacingErrorMessages #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions lib/TaskProcessing/TextToImageProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
use OCP\IAppConfig;
use OCP\IL10N;
use OCP\TaskProcessing\EShapeType;
use OCP\TaskProcessing\Exception\ProcessingException;
use OCP\TaskProcessing\Exception\UserFacingProcessingException;
use OCP\TaskProcessing\ISynchronousWatermarkingProvider;
use OCP\TaskProcessing\ShapeDescriptor;
use OCP\TaskProcessing\TaskTypes\TextToImage;
use Psr\Log\LoggerInterface;
use RuntimeException;

class TextToImageProvider implements ISynchronousWatermarkingProvider {

Expand Down Expand Up @@ -110,19 +111,29 @@ public function process(?string $userId, array $input, callable $reportProgress,
$startTime = time();

if (!isset($input['input']) || !is_string($input['input'])) {
throw new RuntimeException('Invalid prompt');
throw new ProcessingException('Invalid prompt');
}
$prompt = $input['input'];

$nbImages = 1;
if (isset($input['numberOfImages']) && is_int($input['numberOfImages'])) {
$nbImages = $input['numberOfImages'];
}
if ($nbImages > 12) {
throw new UserFacingProcessingException('numberOfImages is out of bounds', userFacingMessage: $this->l->t('Cannot generate more than 12 images at once'));
}
Comment on lines +122 to +124
Copy link
Contributor

@kyteinsky kyteinsky Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to make this a class or Application constant

if ($nbImages < 1) {
throw new UserFacingProcessingException('numberOfImages is out of bounds', userFacingMessage: $this->l->t('Cannot generate less than 1 image'));
}

$size = $this->appConfig->getValueString(Application::APP_ID, 'default_image_size', lazy: true) ?: Application::DEFAULT_DEFAULT_IMAGE_SIZE;
if (isset($input['size']) && is_string($input['size']) && preg_match('/^\d+x\d+$/', $input['size'])) {
$size = trim($input['size']);
}
[$x, $y] = explode('x', $size, 2);
if ((int)$x > 4096 || (int)$y > 4096) {
throw new UserFacingProcessingException('size is out of bounds', userFacingMessage: $this->l->t('Cannot generate images larger than 4096x4096'));
}

if (isset($input['model']) && is_string($input['model'])) {
$model = $input['model'];
Expand Down Expand Up @@ -150,7 +161,7 @@ public function process(?string $userId, array $input, callable $reportProgress,

if (empty($urls) && empty($b64s)) {
$this->logger->warning('OpenAI/LocalAI\'s text to image generation failed: no image returned');
throw new RuntimeException('OpenAI/LocalAI\'s text to image generation failed: no image returned');
throw new ProcessingException('OpenAI/LocalAI\'s text to image generation failed: no image returned');
}
$client = $this->clientService->newClient();
$requestOptions = $this->openAiAPIService->getImageRequestOptions($userId);
Expand All @@ -172,7 +183,7 @@ public function process(?string $userId, array $input, callable $reportProgress,
return $output;
} catch (\Exception $e) {
$this->logger->warning('OpenAI/LocalAI\'s text to image generation failed with: ' . $e->getMessage(), ['exception' => $e]);
throw new RuntimeException('OpenAI/LocalAI\'s text to image generation failed with: ' . $e->getMessage());
throw new ProcessingException('OpenAI/LocalAI\'s text to image generation failed with: ' . $e->getMessage());
}
}
}
Loading