[TODO] Adjust to breaking changes in the Files frontend API in NC 33 #938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues are disabled in this project so here I am with a fake PR 😁
cc @artonge
There are breaking changes in the Files frontend API that break the file actions and the file sidebar in this app on NC >= 33.
The file actions
This one should be simple to adjust.
See how it's been done in the approval app: nextcloud/approval#350
You need
@nextcloud/files4.0.0-beta.x (currently beta.9).The file sidebar tab
It's been done in the approval app as well: nextcloud/approval#355
Approval has been migrated to Vue 3, I don't know how different is the custom element stuff in Vue 2.
This is a slightly deeper change. The sidebar tab is now registered as a custom DOM element made out of a Vue component. The component will get the current selected file as a prop.