Skip to content

Conversation

@mpivchev
Copy link
Collaborator

@mpivchev mpivchev commented Nov 14, 2024

  • Added option to enforce lock
  • Added option to change passcode
  • Changed some strings
  • Hid options related to lock when it's off

Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev mpivchev marked this pull request as ready for review November 15, 2024 15:35
@mpivchev mpivchev linked an issue Nov 15, 2024 that may be closed by this pull request
mpivchev and others added 8 commits November 18, 2024 15:00
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Copy link
Contributor

@i2h3 i2h3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not rely on my review alone but also another one because I am still new to the project.

.onChange(of: model.resetWrongAttempts) { _ in
model.updateResetWrongAttemptsSetting()
}
.font(.system(size: 16))

This comment was marked as resolved.

@marinofaggiana
Copy link
Member

pls. rebase DB version changed

Copy link
Member

@marinofaggiana marinofaggiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note.

var disable_show_more_nextcloud_apps_in_settings: Bool = false
var doNotAskPasscodeAtStartup: Bool = false
var disable_source_code_in_settings: Bool = false
var enforce_protection = true

This comment was marked as resolved.

@marinofaggiana

This comment was marked as resolved.

@marinofaggiana
Copy link
Member

Please do not rely on my review alone but also another one because I am still new to the project.

@i2h3 you can also try if it works, first of all

@mpivchev
Copy link
Collaborator Author

image image

More changes @marinofaggiana

@mpivchev
Copy link
Collaborator Author

mpivchev commented Nov 26, 2024

More improvements to localization and formatting:

image image image

@marinofaggiana
Copy link
Member

marinofaggiana commented Nov 27, 2024

@mpivchev :

PLS enforce_protection = false

The icon ? mmmm have you pushed ?

The Do not ask at startup doesn't it always have to be false or the hidden option?

Screenshot 2024-11-27 alle 14 28 56

@marinofaggiana marinofaggiana self-requested a review November 27, 2024 13:30
@marinofaggiana marinofaggiana requested a review from i2h3 November 27, 2024 13:30
@i2h3
Copy link
Contributor

i2h3 commented Nov 27, 2024

@i2h3 you can also try if it works, first of all

@marinofaggiana I do not know how yet. I know MDM only in theory. I need to get in contact with Milen first on how that actually works for the Nextcloud app.

@marinofaggiana
Copy link
Member

@i2h3 you can also try if it works, first of all

@marinofaggiana I do not know how yet. I know MDM only in theory. I need to get in contact with Milen first on how that actually works for the Nextcloud app.

not important MDM, this is only a switch ( enforce_protection = false / true ) which can also be used in MDM but also not, you can safely do a test by putting enforce_protection on TRUE

Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@i2h3
Copy link
Contributor

i2h3 commented Nov 28, 2024

@mpivchev When is the pass code required other than bringing the app to foreground? Enabling a pass code and disabling its requirement on launch is not clear to me.

i2h3

This comment was marked as resolved.

mpivchev and others added 5 commits November 28, 2024 11:28
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Marino Faggiana <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev
Copy link
Collaborator Author

mpivchev commented Nov 28, 2024

@mpivchev When is the pass code required other than bringing the app to foreground? Enabling a pass code and disabling its requirement on launch is not clear to me.

Passcode is used for starting the app and for encrypted folders

"Enabling a pass code and disabling its requirement on launch is not clear to me." Fixed. Now option to disable passcode on launch is hidden when enforced.

mpivchev and others added 7 commits November 28, 2024 16:18
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev mpivchev merged commit 0c15599 into develop Nov 29, 2024
5 checks passed
@mpivchev mpivchev deleted the enfore_lock branch March 12, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MDM: enforce app protection (biometric/faceid)

4 participants