Skip to content

[stable31] fix: replace axios types import source #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antreesy merged 3 commits into from
Mar 11, 2025
Merged

[stable31] fix: replace axios types import source #1558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0049b8
fix: replace axios types import
Antreesy Mar 10, 2025
2e63456
fix(deps): remove axios library from dependencies
Antreesy Mar 10, 2025
70c8b6b
chore(assets): Recompile assets
nextcloud-command Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/logreader-main.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
"@nextcloud/router": "^3.0.0",
"@nextcloud/typings": "^1.9.1",
"@nextcloud/vue": "^8.22.0",
"axios": "^1.7.9",
"date-fns": "^3.6.0",
"highlight.js": "^11.11.1",
"json-string-splitter": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import type { AxiosRequestConfig, AxiosResponse } from '@nextcloud/axios'
import type { IAppSettings, INextcloud22LogEntry } from './interfaces'
import type { AxiosRequestConfig, AxiosResponse } from 'axios'

import { generateUrl } from '@nextcloud/router'
import axios from '@nextcloud/axios'
Expand Down Expand Up @@ -42,7 +42,7 @@
*
* @param data Parameters for request
* @param config Axios config for setting data
* @return Array of fetched log entries

Check warning on line 45 in src/api.ts

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @return type
* @throws AxiosError with HTTP status 424 if log type is not set to `file`
*/
export const getLog = (data: ApiGetLog, config: AxiosRequestConfig<ApiGetLog> = {}) => axios.get<ApiLogResult, AxiosResponse<ApiLogResult, ApiGetLog>>(generateUrl('apps/logreader/api/log'), { ...config, params: data }) as Promise<AxiosResponse<ApiLogResult>>
Expand All @@ -52,7 +52,7 @@
*
* @param data Parameters for request
* @param config Axios config for setting data
* @return Array of fetched log entries

Check warning on line 55 in src/api.ts

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @return type
* @throws AxiosError with HTTP status 424 if log type is not set to `file`
*/
export const pollLog = (data: ApiPollLog, config: AxiosRequestConfig<ApiPollLog> = {}) => axios.get<ApiPollLogResult, AxiosResponse<ApiPollLogResult, ApiPollLog>>(generateUrl('apps/logreader/api/poll'), { ...config, params: data }) as Promise<AxiosResponse<ApiPollLogResult>>
Expand All @@ -62,7 +62,7 @@
*
* @param data Parameters for request
* @param config Axios config for setting data
* @return

Check warning on line 65 in src/api.ts

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @return type
*/
export const setAppSetting = <K extends IAppSettingsKey>(data: ApiSetAppSetting<K>, config: AxiosRequestConfig<ApiSetAppSetting<K>> = {}) => axios.put<void, AxiosResponse<void, ApiSetAppSetting<K>>>(generateUrl('apps/logreader/api/settings'), data, config)

Expand All @@ -71,6 +71,6 @@
*
* @param data Request parameters
* @param config Optional Axios request config
* @return The current app config

Check warning on line 74 in src/api.ts

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @return type
*/
export const getAppSettings = (data?: ApiGetAppSettings, config: AxiosRequestConfig<ApiGetAppSettings> = {}) => axios.get<IAppSettings, AxiosResponse<IAppSettings, ApiGetAppSettings>>(generateUrl('apps/logreader/api/settings'), { ...config, params: data })
2 changes: 1 addition & 1 deletion src/store/logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import type { AxiosError } from 'axios'
import type { AxiosError } from '@nextcloud/axios'
import type { ILogEntry } from '../interfaces'

import { defineStore } from 'pinia'
Expand Down Expand Up @@ -101,7 +101,7 @@
hasRemainingEntries.value = false
}

/**

Check warning on line 104 in src/store/logging.ts

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @param "text" declaration
* Load entries from string
*/
async function loadText(text: string) {
Expand Down
Loading