-
Notifications
You must be signed in to change notification settings - Fork 295
fix: ensure drafts folder exists #11889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d460f73 to
28fe577
Compare
| if ($draftsMailboxId === null) { | ||
| return $this->mailManager->createMailbox( | ||
| $account, | ||
| 'Drafts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably translate it, but if the server doesn’t support storing the special-use flag, guessing the special use from the folder name will fail since we don’t know that “Entwürfe” means “Drafts”. So using the untranslated version is the safer option.
d8cfcf3 to
59d310b
Compare
59d310b to
769465c
Compare
769465c to
14e2b73
Compare
DerDreschner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested fine.
Only thing is that the list of folders should update in the UI after saving the draft to the IMAP server (if the folder doesn't exist, of course). Needs a manual page reload, which can be a bit confusing for some as it appears the message is gone at first. Maybe we should open a follow up ticket for that?
14e2b73 to
7625e73
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
7625e73 to
c01706f
Compare
|
/backport to stable5.6 |
No description provided.