Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 7, 2025

No description provided.

@kesselb kesselb force-pushed the fix/noid/create-drafts-folder-on-demand branch from d460f73 to 28fe577 Compare October 7, 2025 18:06
if ($draftsMailboxId === null) {
return $this->mailManager->createMailbox(
$account,
'Drafts',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably translate it, but if the server doesn’t support storing the special-use flag, guessing the special use from the folder name will fail since we don’t know that “Entwürfe” means “Drafts”. So using the untranslated version is the safer option.

@kesselb kesselb force-pushed the fix/noid/create-drafts-folder-on-demand branch from d8cfcf3 to 59d310b Compare October 7, 2025 19:14
@kesselb kesselb marked this pull request as ready for review October 7, 2025 19:28
@kesselb kesselb self-assigned this Oct 7, 2025
@kesselb kesselb force-pushed the fix/noid/create-drafts-folder-on-demand branch from 59d310b to 769465c Compare December 22, 2025 15:26
@kesselb kesselb force-pushed the fix/noid/create-drafts-folder-on-demand branch from 769465c to 14e2b73 Compare January 13, 2026 09:49
@kesselb kesselb requested a review from DerDreschner January 13, 2026 09:53
Copy link
Contributor

@DerDreschner DerDreschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fine.

Only thing is that the list of folders should update in the UI after saving the draft to the IMAP server (if the folder doesn't exist, of course). Needs a manual page reload, which can be a bit confusing for some as it appears the message is gone at first. Maybe we should open a follow up ticket for that?

@kesselb kesselb force-pushed the fix/noid/create-drafts-folder-on-demand branch from 14e2b73 to 7625e73 Compare January 14, 2026 13:50
@kesselb kesselb requested a review from GretaD as a code owner January 14, 2026 13:50
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the fix/noid/create-drafts-folder-on-demand branch from 7625e73 to c01706f Compare January 14, 2026 13:59
@kesselb
Copy link
Contributor Author

kesselb commented Jan 14, 2026

/backport to stable5.6

@kesselb kesselb enabled auto-merge January 14, 2026 14:09
@kesselb kesselb merged commit 0478031 into main Jan 14, 2026
46 checks passed
@kesselb kesselb deleted the fix/noid/create-drafts-folder-on-demand branch January 14, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants