fix: use filepicker API for placing photos on the map#1464
Merged
Conversation
32e84f1 to
34ad9b1
Compare
With Nextcloud 28 the `OC.dialogs` API was deprecated, instead we need to use `@nextcloud/dialogs` for the filepicker. So this fixes: 1. The deprecated `OC.dialogs` usage 2. Bug where both dialogs where opened at the same time (file and folder picker). 3. Properly place photos on other than the default map Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
rebased |
tacruc
approved these changes
Nov 26, 2025
Collaborator
tacruc
left a comment
There was a problem hiding this comment.
Hi Sunex thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Nextcloud 28 the
OC.dialogsAPI was deprecated, instead we need to use@nextcloud/dialogsfor the filepicker. So this fixes:OC.dialogsusage