Fix: Correct path in settings to load the actual path#1380
Closed
christianlupus wants to merge 2 commits intomainfrom
Closed
Fix: Correct path in settings to load the actual path#1380christianlupus wants to merge 2 commits intomainfrom
christianlupus wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Member
|
Apparently the same fix is already open in #1342, closing as dup. |
Member
|
reopening, as it goes against main, contrary to the other PR |
Contributor
|
I tried to reproduce #1375, and it works without infinitely loading. If you can still reproduce, feel free to reopen. I'm using Chrome on MacOS -- maybe it's environment specific |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1375
This is just a quick fix for the bug in order to test further. I am not sure if this is the right way to do it as this might as well be an issue with the underlying
@nextcloud/dialogslibrary, I am not sure about this, though.