Migrate notes search to NcTextField with clear button #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korelstar
added
feature: app navigation
korelstar
requested review from
JuliaKirschenheuter and
enjeck
as code owners
korelstar
force-pushed
the
clear-search
branch
from
629cf26 to
bc2f986
Compare
JuliaKirschenheuter
approved these changes
Nov 12, 2024
Contributor
JuliaKirschenheuter
left a comment
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
Thanks for taking over!
korelstar
force-pushed
the
clear-search
branch
from
bc2f986 to
578d736
Compare
juliusknorr
approved these changes
Nov 26, 2024
juliusknorr
force-pushed
the
clear-search
branch
from
578d736 to
bbc43d4
Compare
korelstar
force-pushed
the
clear-search
branch
from
bbc43d4 to
138e81a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search input field for searching notes did not have a button for clearing the input value. However, this is standard in many input fields used in Nextcloud. Therefore, this PR migrates the HTML input field into a
NcTextFieldwhich automatically has a button for clearing the input value.Before:
After:
