feat(ui): switch to outline icons #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
elzody,
luka-nextcloud and
marcoambrosini
JuliaKirschenheuter
force-pushed
the
enh/1587-Use-outline-icons
branch
from
7c284e6 to
8ef6cdf
Compare
grnd-alt
approved these changes
Jul 21, 2025
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Just one last change @JuliaKirschenheuter
JuliaKirschenheuter
force-pushed
the
enh/1587-Use-outline-icons
branch
from
8ef6cdf to
385ecc9
Compare
Contributor
Author
|
@marcoambrosini, done ;) looks ok now? |
marcoambrosini
approved these changes
Jul 25, 2025
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Just one small change. As a guideline, we don't want outline version of icons that are made of only lines.
So, the plus icon is made of 2 lines, does not have a fill:
We should keep that, and not use this:
Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
force-pushed
the
enh/1587-Use-outline-icons
branch
from
385ecc9 to
0b14c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1587
For all leftover icons: #1587 (comment)