Draft
Conversation
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Fix master password bypasses.
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Fixed extension lock.
Minor UX improvements.
Removed unexpected property from manifest.json.
Added label for username in search-result.
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Fixed variables & descriptions in translations.
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
Signed-off-by: Niklas Schmitt <niklas.schmitt@mailbox.org>
use the existing wasm passkey implementation from 1password (passkey-rs) compiled by proton to webassembly as the basis for adding passkeys to the extension. This commit adds all the mechanics of passkeys but no backend storage. Note that the overriding of nagivator.credentials.get and .create only works on Firefox. To get it to work on Chrome, the manifest version will have to be updated to v3 so the injector can use world: main to hijack the methods. When this happens, the injector will have to have a main and isolated component that communicate using window events due to the new restriction on main scripts not being able to use backend APIs. Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Since the database theoretically needs expanding for additional primary fields (which causes versioning issues) just shovel the passkey into a hidden custom field. Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft placeholder showing how passkeys can be added to passman using the 1password rust implementation
compiled to webassembly. Currently tested with these sites
https://passkeys-demo.appspot.com/
https://www.passkeys.io/
and as a live site smoke test
https://amazon.com
Due to problems with database modifications for backend support, the passkey is currently stored in the (encrypted) custom fields under a bogus field name. In order to build (for those who would like to try it), this is based of the buildable base of pull #346 so only the top two commits contain passkey code (separated into website and backend)