Skip to content

[stable8] (U) Fix to ClusterFacesJob.php in Instances with Numeric User IDs #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 1 commit into from
Jan 9, 2025
Merged

[stable8] (U) Fix to ClusterFacesJob.php in Instances with Numeric User IDs #1230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/BackgroundJobs/ClusterFacesJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
* @return void
*/
protected function run($argument) {
/** @var string $userId */

Check failure on line 40 in lib/BackgroundJobs/ClusterFacesJob.php

View workflow job for this annotation

GitHub Actions / Nextcloud (8.1, dev-stable30)

UnnecessaryVarAnnotation 

lib/BackgroundJobs/ClusterFacesJob.php:40:12: UnnecessaryVarAnnotation: The @var string annotation for $userId is unnecessary (see https://psalm.dev/212)

Check failure on line 40 in lib/BackgroundJobs/ClusterFacesJob.php

View workflow job for this annotation

GitHub Actions / Nextcloud (8.2, dev-stable30)

UnnecessaryVarAnnotation 

lib/BackgroundJobs/ClusterFacesJob.php:40:12: UnnecessaryVarAnnotation: The @var string annotation for $userId is unnecessary (see https://psalm.dev/212)

Check failure on line 40 in lib/BackgroundJobs/ClusterFacesJob.php

View workflow job for this annotation

GitHub Actions / Nextcloud (8.3, dev-stable30)

UnnecessaryVarAnnotation 

lib/BackgroundJobs/ClusterFacesJob.php:40:12: UnnecessaryVarAnnotation: The @var string annotation for $userId is unnecessary (see https://psalm.dev/212)
$userId = $argument['userId'];
$userId = (string) $argument['userId'];
try {
$this->clusterAnalyzer->calculateClusters($userId, self::BATCH_SIZE);
} catch (\JsonException|Exception $e) {
Expand Down
Loading