Skip to content

Conversation

@marcelklehr
Copy link
Member

fixes #1347

@marcelklehr marcelklehr requested a review from Copilot August 29, 2025 09:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a database migration issue where a new column was being created with a not-null constraint without providing a default value, which would cause migration failures on existing databases with data.

  • Changed the face_vector column creation to allow null values initially
  • Added a subsequent migration to set the column to not-null after creation
  • Improved migration logic to handle multiple column operations in a single migration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/Migration/Version010000001Date20250727094721.php Modified column creation to allow null values initially
lib/Migration/Version010000001Date20250727094821.php Added logic to set column to not-null and improved return handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marcelklehr
Copy link
Member Author

/backport to stable9

@marcelklehr
Copy link
Member Author

/backport to stable10

@marcelklehr marcelklehr merged commit 812a9d8 into stable10 Aug 29, 2025
39 of 41 checks passed
@backportbot
Copy link

backportbot bot commented Aug 29, 2025

The backport to stable10 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable10
git pull origin stable10

# Create the new backport branch
git checkout -b backport/1350/stable10

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5410b6d2 e79f8ebc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1350/stable10

Error: Failed to check for changes with origin/stable10: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@marcelklehr
Copy link
Member Author

/backport to stable8

@backportbot
Copy link

backportbot bot commented Aug 29, 2025

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/1350/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5410b6d2 e79f8ebc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1350/stable8

Error: Failed to check for changes with origin/stable8: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants