Skip to content

[stable10] fix(InstallDeps): Set write permissions on node_modules folder #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 1 commit into from
Sep 16, 2025
Merged

[stable10] fix(InstallDeps): Set write permissions on node_modules folder #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions lib/Migration/InstallDeps.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ final class InstallDeps implements IRepairStep {
private string $ffmpegInstallScript;
private string $tfjsGPUPath;
private IBinaryFinder $binaryFinder;
private string $nodeModulesDir;

public function __construct(IAppConfig $config, IClientService $clientService, LoggerInterface $logger, IBinaryFinder $binaryFinder) {
$this->config = $config;
$this->binaryDir = dirname(__DIR__, 2) . '/bin/';
$this->nodeModulesDir = dirname(__DIR__, 2) . '/node_modules/';
$this->preGypBinaryDir = dirname(__DIR__, 2) . '/node_modules/@mapbox/node-pre-gyp/bin/';
$this->ffmpegDir = dirname(__DIR__, 2) . '/node_modules/ffmpeg-static/';
$this->ffmpegInstallScript = dirname(__DIR__, 2) . '/node_modules/ffmpeg-static/install.js';
Expand Down Expand Up @@ -89,6 +91,7 @@ public function run(IOutput $output): void {
$this->runTfjsInstall($binaryPath);
$this->runFfmpegInstall($binaryPath);
$this->runTfjsGpuInstall($binaryPath);
$this->setNodeModulesPermissions();
$this->setNiceBinaryPath();
} catch (\Throwable $e) {
$output->warning('Failed to automatically install dependencies for recognize. Check the recognize admin panel for potential problems.');
Expand Down Expand Up @@ -268,6 +271,24 @@ protected function setBinariesPermissions(): void {
}
}

/**
* Set write permissions recursively for node_modules
*/
protected function setNodeModulesPermissions(): void {
$iterator = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($this->nodeModulesDir));
/** @var \SplFileInfo $item */
foreach ($iterator as $item) {
$realpath = realpath($item->getPathname());
if ($realpath === false || ($item->getPerms() & 0700) === 0700) {
continue;
}
$mode = $item->isDir() ? 0755 : 0644;
if (chmod($realpath, $mode) === false) {
throw new \Exception('Error when setting '.$this->nodeModulesDir.'* permissions: ' . $realpath);
}
}
}

protected function isAVXSupported(): bool {
try {
$cpuinfo = file_get_contents('/proc/cpuinfo');
Expand Down
Loading