Skip to content

Conversation

@marcelklehr
Copy link
Member

fixes #1383

@marcelklehr marcelklehr requested a review from Copilot September 18, 2025 08:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #1383 by updating the FileListener to listen to user mount events instead of share events. The change improves how the system detects when files become accessible to users through mount operations.

Key changes:

  • Switches from ShareAcceptedEvent to UserMountAddedEvent and UserMountRemovedEvent
  • Refactors getUsersWithFileAccess method to accept node ID instead of Node object
  • Adds logic to handle mount addition/removal with deduplication

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lib/Hooks/FileListener.php Core changes to handle mount events, refactor access detection method, and add mount tracking logic
lib/AppInfo/Application.php Updates event listener registration to conditionally use mount events or fall back to share events

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@val-kulkov
Copy link

Confirming that this PR fixes issue #1383.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marcelklehr marcelklehr marked this pull request as ready for review September 22, 2025 09:09
Copy link
Contributor

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marcelklehr marcelklehr merged commit 952f295 into main Sep 22, 2025
42 checks passed
@marcelklehr
Copy link
Member Author

/backport stable10

@marcelklehr
Copy link
Member Author

/backport stable9

@marcelklehr
Copy link
Member Author

/backport to stable10

@marcelklehr
Copy link
Member Author

/backport to stable9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

images in a shared folder are not processed upon addition to user's timeline path

4 participants