-
Notifications
You must be signed in to change notification settings - Fork 55
fix(FileListener): Listen to user mount events #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issue #1383 by updating the FileListener to listen to user mount events instead of share events. The change improves how the system detects when files become accessible to users through mount operations.
Key changes:
- Switches from ShareAcceptedEvent to UserMountAddedEvent and UserMountRemovedEvent
- Refactors getUsersWithFileAccess method to accept node ID instead of Node object
- Adds logic to handle mount addition/removal with deduplication
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/Hooks/FileListener.php | Core changes to handle mount events, refactor access detection method, and add mount tracking logic |
| lib/AppInfo/Application.php | Updates event listener registration to conditionally use mount events or fall back to share events |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9d97e14 to
b72c6b6
Compare
|
Confirming that this PR fixes issue #1383. |
fixes #1383 Signed-off-by: Marcel Klehr <[email protected]>
b72c6b6 to
07d72cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
kyteinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
/backport stable10 |
|
/backport stable9 |
|
/backport to stable10 |
|
/backport to stable9 |
fixes #1383