Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 13, 2024

Fix #4313

Follow up to #4101 as my cypress test did not assert that the document was loaded, when doing so the test was still failing. It turned out that i used the wrong method to get the template file which would work when I manually tested with user defined templates but not with the default empty template files.

@juliusknorr juliusknorr requested a review from elzody as a code owner December 13, 2024 11:06
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Dec 13, 2024
@juliusknorr juliusknorr self-assigned this Dec 13, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@juliusknorr juliusknorr merged commit 43df790 into main Dec 18, 2024
73 checks passed
@juliusknorr juliusknorr deleted the fix/template-direct branch December 18, 2024 15:57
@juliusknorr
Copy link
Member Author

/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable30

@juliusknorr
Copy link
Member Author

/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable29

@juliusknorr
Copy link
Member Author

/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable28

@juliusknorr
Copy link
Member Author

/backport to stable30

@juliusknorr
Copy link
Member Author

/backport to stable29

@backportbot
Copy link

backportbot bot commented Mar 13, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/4335/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cb664d63

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4335/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Mar 13, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/4335/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cb664d63

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4335/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

Archived in project

3 participants