-
Notifications
You must be signed in to change notification settings - Fork 140
fix: Properly get empty template for direct editing #4335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julius Knorr <[email protected]>
elzody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable30 |
|
/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable29 |
|
/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable28 |
|
/backport to stable30 |
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/4335/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cb664d63
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4335/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/4335/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick cb664d63
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4335/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Fix #4313
Follow up to #4101 as my cypress test did not assert that the document was loaded, when doing so the test was still failing. It turned out that i used the wrong method to get the template file which would work when I manually tested with user defined templates but not with the default empty template files.