fix: Generate preview with proper aspect ratio for templates #4386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Not sure why psalm just fails now, but it is due to wrong phpdoc in server: nextcloud/server#50196 |
Contributor
|
looks like there is a merge conflict on |
Member
Author
|
Yes, I manually bumped the package, but was done separately on main meanwhile |
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/template-preview-aspect-ratio
branch
from
cb1c8f0 to
920cf96
Compare
Member
Author
|
Rebased |
elzody
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Before this change we injected a square preview that looked odd in the tempalte picker with others coming from the server template directory having the aspect ratio of the document.