Skip to content

fix: translation format specifier #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elzody merged 2 commits into from
Jan 24, 2025
Merged

fix: translation format specifier #4411

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e2f686
fix: translation format specifier
elzody Jan 24, 2025
319d65b
feat: add more context for translators
elzody Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Conversion/ConversionProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,10 @@ public function convertFile(File $file, string $targetMimeType): mixed {
private function getMimeProvidersFor(array $inputMimeTypes, string $outputMimeType): array {
$outputMimeInfo = $this->getMimeInfoFor($outputMimeType);
if ($outputMimeInfo === null) {
$this->logger->error($this->l10n->t('Unable to fetch information on $s', [$outputMimeType]));
$this->logger->error(
$this->l10n->t('Unable to fetch information on %1$s',
[$outputMimeType]
));
throw new \Exception();
}

Expand Down
Loading