Merged
Conversation
elzody
force-pushed
the
fix/make-ci-green-again
branch
from
2a61c58 to
f61946e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
elzody
force-pushed
the
fix/make-ci-green-again
branch
2 times, most recently
from
6b76490 to
43a178d
Compare
juliusknorr
reviewed
Feb 25, 2025
juliusknorr
approved these changes
Feb 25, 2025
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks good, somewhat overlaps with #4520
elzody
force-pushed
the
fix/make-ci-green-again
branch
2 times, most recently
from
1e6ce08 to
b1e4f60
Compare
The problematic code is related to an issue that is difficult to trace therefore to get CI passing to allow other merges in the meantime I comment it out until it is resolved. Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
elzody
force-pushed
the
fix/make-ci-green-again
branch
from
2dbdb9e to
fc5cbfc
Compare
Member
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making CI green again required the following:
The code which was commented out breaks functionality when present in the code base, thus until the issue is resolved it has been commented so we can get CI green again and continue merging important fixes without haggling with Cypress.