fix(mobile): pass format to SaveAs #5208
Conversation
Minion3665
force-pushed
the
private/minion/push-rqvmksmlmlym
branch
from
3b6f488 to
775d509
Compare
Minion3665
force-pushed
the
private/minion/push-rqvmksmlmlym
branch
from
775d509 to
4fc08af
Compare
With direct access, used in the mobile app, `args.format` was typoed as `args.Format`, leading to format always being undefined. This meant that the save as popup would use the extension of the current file rather than the extension you were trying to save as. You could workaround by editing this manually, but it was annoying and not working as intended. The browser version wasn't broken, as it uses a different code path to save documents (see src/mixins/saveAs.js) Signed-off-by: Skyler Grey <[email protected]>
Minion3665
force-pushed
the
private/minion/push-rqvmksmlmlym
branch
from
4fc08af to
9ab3d5b
Compare
|
Multiple force pushes to fix tests and update commit messages, cumulatively |
|
/backport to stable32 please |
|
/backport to stable31 please |
|
/backport to stable30 please |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@juliusknorr I added myself to the blocklist a while back, do you mind taking a look at why I still got the bot comment here? Thanks! |
|
Indeed, it seems casing matters here: nextcloud/.github#649 |
|
ahhh 🤦🏼♀️ - thanks very much for checking that for me! |
3 participants
In the mobile app,
args.formatwas typoed asargs.Format, leading to format always being undefined. This meant that the save as popup would use the extension of the current file rather than the extension you were trying to save as. You could workaround by editing this manually, but it was annoying and not working as intended...The browser version wasn't broken, as it uses a different code path to save documents (see src/mixins/saveAs.js)
Summary
TODO
Checklist