fix: Properly work with non-numeric version ids#5237
Open
juliusknorr wants to merge 1 commit intomainfrom
Open
fix: Properly work with non-numeric version ids#5237juliusknorr wants to merge 1 commit intomainfrom
juliusknorr wants to merge 1 commit intomainfrom
Conversation
1fce582 to
06d4b6c
Compare
Signed-off-by: Julius Knorr <jus@bitgrid.net>
06d4b6c to
3807c38
Compare
elzody
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using https://github.com/nextcloud/files_versions_s3 version ids in Nextcloud may not be numberic, but:
This PR changes the database schema of richdocuments to make it work with that and adapts code where we enforce numeric values
To test with minio and primary object storage: