fix: Remove hasDrawSupport check that strips .odg mimetypes#5367
Merged
Conversation
hasDrawSupport() checked whether Collabora was at least version 6.4.7. When the Collabora capabilities cache was empty (between background job refreshes), productVersion defaulted to '0.0.0.0', causing the check to strip .odg and .odg-flat-xml mimetypes from the OCS capabilities. This prevented .odg files from being opened in the viewer. Collabora 6.4.7 was released years ago and no supported Nextcloud version ships with anything older — remove the check entirely. Signed-off-by: Andras Timar <andras.timar@collabora.com>
timar
force-pushed
the
private/timar/hasdrawsupport
branch
from
f9aac50 to
2259725
Compare
elzody
approved these changes
Feb 13, 2026
Contributor
|
Thanks a lot for handling this! |
Contributor
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasDrawSupport() checked whether Collabora was at least version 6.4.7. When the Collabora capabilities cache was empty (between background job refreshes), productVersion defaulted to '0.0.0.0', causing the check to strip .odg and .odg-flat-xml mimetypes from the OCS capabilities. This prevented .odg files from being opened in the viewer.
Collabora 6.4.7 was released years ago and no supported Nextcloud version ships with anything older — remove the check entirely.