fix: Properly annotate settings controller#5416
Merged
Conversation
juliusknorr
force-pushed
the
fix/settings-annotatin
branch
from
1aac22c to
8d5dd0c
Compare
Member
Author
|
/backport! to stable33 |
Member
Author
|
/backport! to stable32 |
Member
Author
|
/backport! to stable31 |
This was referenced Feb 19, 2026
Member
Author
|
/backport! to stable32 |
2 tasks
elzody
force-pushed
the
fix/settings-annotatin
branch
from
8d5dd0c to
292c8ec
Compare
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
force-pushed
the
fix/settings-annotatin
branch
from
1527e36 to
4c01acf
Compare
elzody
approved these changes
Feb 19, 2026
Collaborator
There was a problem hiding this comment.
Needed to adjust the workflow a bit as the Behat tests were not even running. Also needed to fix a failure once they did run by add index.php to the base URI for richdocuments requests in admin-settings.feature. I will back-port those fixes specifically to the stable32, as that back-port has already been merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist