Skip to content

Conversation

@leftybournes
Copy link
Contributor

No description provided.

@leftybournes leftybournes force-pushed the leftybournes/fix/stable29-backports branch from e7af913 to 8089fab Compare December 18, 2025 07:29
Signed-off-by: Kent Delante <[email protected]>
@leftybournes leftybournes force-pushed the leftybournes/fix/stable29-backports branch from 8f6158a to 1a58a72 Compare December 19, 2025 05:14
@leftybournes leftybournes force-pushed the leftybournes/fix/stable29-backports branch from 1a58a72 to 32cb3bb Compare December 19, 2025 05:28
@icewind1991
Copy link
Member

I'm not sure if a move command like this is the correct option. (Only setting the stored instance, not moving an actual object). Or if we want to extend https://github.com/nextcloud/multibucket_migrate instead, which does perform the object moving.

$count = 0;
foreach ($users as $user) {
if (!$input->getOption('dry-run')) {
$this->config->setUserValue($user->getUID(), 'homeobjectstore', 'objectstore', $objectStore);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with this version of the move command, I think it makes sense to validate that the target object store is valid for the user.

We could get the fileid for one of the user's files (if the user has at least one file) and check if an object with the matching urn exists it the target object store.

Without any checks the command would risk being a big footgun.

@icewind1991
Copy link
Member

Outside of the move command the changes look good

Signed-off-by: Kent Delante <[email protected]>
@leftybournes leftybournes force-pushed the leftybournes/fix/stable29-backports branch from 6b1a26e to fc30176 Compare December 23, 2025 07:39
@leftybournes
Copy link
Contributor Author

I'm not sure if a move command like this is the correct option. (Only setting the stored instance, not moving an actual object). Or if we want to extend https://github.com/nextcloud/multibucket_migrate instead, which does perform the object moving.

I think extending multibucket_migrate is the way to go since that's already available instead of adding the move command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants