-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable29] multi-instance object store tweaks #57141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable29-backports
Are you sure you want to change the base?
[stable29] multi-instance object store tweaks #57141
Conversation
Signed-off-by: Kent Delante <[email protected]>
e7af913 to
8089fab
Compare
Signed-off-by: Kent Delante <[email protected]>
8f6158a to
1a58a72
Compare
Signed-off-by: Kent Delante <[email protected]>
Signed-off-by: Kent Delante <[email protected]>
1a58a72 to
32cb3bb
Compare
|
I'm not sure if a move command like this is the correct option. (Only setting the stored instance, not moving an actual object). Or if we want to extend https://github.com/nextcloud/multibucket_migrate instead, which does perform the object moving. |
| $count = 0; | ||
| foreach ($users as $user) { | ||
| if (!$input->getOption('dry-run')) { | ||
| $this->config->setUserValue($user->getUID(), 'homeobjectstore', 'objectstore', $objectStore); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with this version of the move command, I think it makes sense to validate that the target object store is valid for the user.
We could get the fileid for one of the user's files (if the user has at least one file) and check if an object with the matching urn exists it the target object store.
Without any checks the command would risk being a big footgun.
|
Outside of the |
Signed-off-by: Kent Delante <[email protected]>
6b1a26e to
fc30176
Compare
I think extending multibucket_migrate is the way to go since that's already available instead of adding the move command. |
No description provided.