[stable29] multi-instance object store tweaks#57141
[stable29] multi-instance object store tweaks#57141leftybournes wants to merge 7 commits intostable29-backportsfrom
Conversation
Signed-off-by: Kent Delante <kent.delante@proton.me>
e7af913 to
8089fab
Compare
Signed-off-by: Kent Delante <kent.delante@proton.me>
8f6158a to
1a58a72
Compare
Signed-off-by: Kent Delante <kent.delante@proton.me>
Signed-off-by: Kent Delante <kent.delante@proton.me>
1a58a72 to
32cb3bb
Compare
|
I'm not sure if a move command like this is the correct option. (Only setting the stored instance, not moving an actual object). Or if we want to extend https://github.com/nextcloud/multibucket_migrate instead, which does perform the object moving. |
|
Outside of the |
Signed-off-by: Kent Delante <kent.delante@proton.me>
6b1a26e to
fc30176
Compare
I think extending multibucket_migrate is the way to go since that's already available instead of adding the move command. |
| ->from('filecache') | ||
| ->where($query->expr()->eq('storage', $query->createNamedParameter($storageId, IQueryBuilder::PARAM_INT))) | ||
| ->andWhere($query->expr()->neq('mimetype', $query->createNamedParameter($folderMimetype, IQueryBuilder::PARAM_INT))); | ||
| $result = $query->execute(); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| ->where($query->expr()->eq('storage', $query->createNamedParameter($storageId, IQueryBuilder::PARAM_INT))) | ||
| ->andWhere($query->expr()->neq('mimetype', $query->createNamedParameter($folderMimetype, IQueryBuilder::PARAM_INT))); | ||
| $result = $query->execute(); | ||
| $fileIds = $result->fetchAll(\PDO::FETCH_COLUMN); |
Check notice
Code scanning / Psalm
PossiblyInvalidMethodCall Note
a3fbe3d to
84f7093
Compare
icewind1991
left a comment
There was a problem hiding this comment.
Apart from changing it to only verify a small number of objects for the move command this looks good to go
84f7093 to
cd1d630
Compare
|
In general, I would suggest throwing exceptions in |
440a4e5 to
ef7e00d
Compare
Signed-off-by: Kent Delante <kent.delante@proton.me>
ef7e00d to
7415781
Compare
Signed-off-by: Kent Delante <kent.delante@proton.me>
No description provided.