-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(settings): update all button only updates a single app #56469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense but I am not sure the problem is really fixed by that? Anyways thats a good semantic code fix
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@susnux @CarlSchwan any chance this can be merged? |
Signed-off-by: Thomas Lamant <[email protected]>
3bd0d84 to
820b846
Compare
Signed-off-by: Thomas Lamant <[email protected]>
820b846 to
6e719ec
Compare
|
Summary
Previously, the chain of functions involved in the "update all apps" routine were not properly setup up with regards to asynchronism:
updateAll()were not awaited or managed properlyupdatefunction fed top-limit'slimit()utility was returning void and not a promise, as it expects (see docs)This was causing the mechanism driving the updates to potentially end prematurely.
This PR fixes this by:
async/awaitandPromises.allinupdateAll()to ensure all promises generated by p-limit are awaited and executed completely before the function finishes.update()return the promises it involvesThis would prevent the function from exiting prematurely and ensure all updates are processed automatically.
Checklist
3. to review, feature component)stable32)