fix(settings): Initialize group display names from store #56509
+107
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
Contributor
Author
|
/compile rebase |
When editing a user, if groups have display names different from their
IDs (e.g., long group names that get hashed), the group selector was
showing the group ID instead of the display name after page reload.
This happened because the `data()` function initialized `userGroups`
with `{ id, name: id }`, setting both fields to the group ID. The fix
adds a `created()` lifecycle hook that looks up the actual group names
from the Vuex store.
Fixes #55785
Signed-off-by: Claude <[email protected]>
Co-Authored-By: Nikolaus Demmel <[email protected]>
Signed-off-by: Nikolaus Demmel <[email protected]>
Add Cypress E2E test to verify that group display names are shown correctly in the user editor, even when the group ID differs from the display name (e.g., when long group names get hashed). The test creates a group with a very long name to trigger Nextcloud's ID hashing behavior, assigns a user to that group, then verifies that after a page reload the display name is shown instead of the hash ID. Related to #55785 Signed-off-by: Claude <[email protected]> Co-Authored-By: Nikolaus Demmel <[email protected]> Signed-off-by: Nikolaus Demmel <[email protected]>
Signed-off-by: Nikolaus Demmel <[email protected]>
Replace crypto-random-string import with Nextcloud's built-in randomString utility to match the pattern used in other Cypress tests. Also add missing testIsolation flag and cleanup hook to follow test conventions used throughout the codebase. Signed-off-by: Nikolaus Demmel <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix-group-display-names-55785
branch
from
469f4e6 to
6b5064e
Compare
Contributor
|
I think that #56524 (using the computed properties) is a bit cleaner. |
6 tasks
CarlSchwan
previously approved these changes
Nov 21, 2025
CarlSchwan
dismissed
their stale review
This is actually the wrong PR to approve
Contributor
Author
Fine for me, I do not know frontend enough to have an opinion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local version of #55871 for CI