fix: allow renaming files with just update permissions #57374
+57
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Member
Author
|
/compile |
icewind1991
added
3. to review
icewind1991
requested review from
Altahrim,
ArtificialOwl,
leftybournes,
provokateurin,
susnux and
szaimen
and removed request for
a team
Signed-off-by: nextcloud-command <[email protected]>
Merged
Member
Author
|
(I'll rebase etc once reviewed) |
Open
mgallien
approved these changes
Jan 9, 2026
Contributor
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
tested with the desktop client and works fine
provokateurin
requested changes
Jan 9, 2026
| if (!($this->info->isDeletable() || ($this->info->getMountPoint() instanceof MoveableMount && $this->info->getInternalPath() === ''))) { | ||
| throw new \Sabre\DAV\Exception\Forbidden(); | ||
| if (!$this->canRename()) { | ||
| throw new \Sabre\DAV\Exception\Forbidden('asd'); |
Member
There was a problem hiding this comment.
Suggested change
| throw new \Sabre\DAV\Exception\Forbidden('asd'); | |
| throw new \Sabre\DAV\Exception\Forbidden(); |
Leftover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only moving to another folder needs the delete+create permissions, for moving in the same folder just update is enough.
TODO: