Skip to content

fix(snowflake): Fix generateId() call for SnowflakeEntity #57410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Jan 7, 2026
+6 −5
Merged

fix(snowflake): Fix generateId() call for SnowflakeEntity #57410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/public/AppFramework/Db/QBMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ public function delete(Entity $entity): Entity {
* @since 14.0.0
*/
public function insert(Entity $entity): Entity {
if ($entity instanceof SnowflakeAwareEntity) {
/** @psalm-suppress DocblockTypeContradiction */
$entity->generateId();
}

// get updated fields to save, fields have to be set using a setter to
// be saved
$properties = $entity->getUpdatedFields();
Expand All @@ -115,11 +120,7 @@ public function insert(Entity $entity): Entity {
$qb->setValue($column, $qb->createNamedParameter($value, $type));
}

if ($entity instanceof SnowflakeAwareEntity) {
/** @psalm-suppress DocblockTypeContradiction */
$entity->generateId();
$qb->executeStatement();
} elseif ($entity->id === null) {
if ($entity->id === null) {
$qb->executeStatement();
// When autoincrement is used id is always an int
$entity->setId($qb->getLastInsertId());
Expand Down
Loading