feat(profile): show Teams memberships on account details #57439
Conversation
Signed-off-by: Cristian Scheid <[email protected]>
cristianscheid
requested review from
artonge,
leftybournes,
provokateurin,
sorbaugh,
susnux and
szaimen
and removed request for
a team
Signed-off-by: Cristian Scheid <[email protected]>
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
It’s a bit sad that we have to turn Circle instances into Team instances, I wonder why Team is not an ITeam interface implemented by Circle 🤷
But I guess it’s too late to change that without breaking API.
A few remarks but looks good 👍
| $team->getDisplayName(), | ||
| $this->urlGenerator->linkToRouteAbsolute('contacts.contacts.directcircle', ['singleId' => $team->getSingleId()]), | ||
| ); | ||
| }, $this->circlesManager->getCircles()); |
There was a problem hiding this comment.
* WARNING: This method is not using Cached Memberships meaning that the request can be heavy and should
* only be used if probeCircles() does not fit your need.
*
* Always prefer probeCircles();
According to circles code it may be better to call probeCircles here?
ping @ArtificialOwl
There was a problem hiding this comment.
Thanks for pointing this out! Just to let you know I've tested locally using probeCircles() instead of getCircles() and it works perfectly.
Following the docblock recommendation, since this fits our use case well, I think probeCircles() is the appropriate way of doing it.
I'll wait for @ArtificialOwl's confirmation before updating the implementation.
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Cristian Scheid <[email protected]>
Signed-off-by: Cristian Scheid <[email protected]>
Summary
Adds Teams (circles) memberships to the personal account details page, providing users with a complete overview of all their group memberships. This enhances the current scenario where only group memberships from connected user backends are displayed, excluding Teams memberships.
Before
After
Checklist
3. to review, feature component)stable32)