feat(files): render file list filters in top bar and allow to collapse into overflow menu #57664
+1,590
−1,313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe and
szaimen
and removed request for
a team
nfebe
reviewed
Jan 21, 2026
nfebe
reviewed
Jan 21, 2026
nfebe
reviewed
Jan 21, 2026
nfebe
approved these changes
Jan 21, 2026
CarlSchwan
approved these changes
Jan 21, 2026
Contributor
|
I just tested this and the new button seems to vanish completely on narrow screens in the latest iteration: Aufzeichnung.2026-01-21.151441.mp4 |
Contributor
Author
|
@szaimen fixed in the latest commit: Bildschirmaufnahme_20260121_153301.webm |
AndyScherzinger
approved these changes
Jan 21, 2026
Merged
…oint Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Contributor
Author
|
/backport to stable33 |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
kra-mo
requested changes
Jan 22, 2026
Member
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
Nice :)
I seem to have a bit of trouble actually testing this branch, but a couple of comments from the screen recordings:
- The "Back to filters" button should be tertiary.
- Is there any gap between the New button and the path bar? There should be some. If yes, no problem :)
- The "Search everywhere" button looks quite cramped there. Maybe just increase its border radius?
- It would be good to expose all folder actions in the dropdown in the path bar, this was a feature request. I'm guessing this is out of scope for this PR, but a new issue should be opened, then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bildschirmaufnahme_20260120_175439.webm
Checklist
3. to review, feature component)stable32)