Skip to content

refactor(systemtags): migrate to Vue 3 and script setup #57855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 3 commits into from
Jan 27, 2026
Merged

refactor(systemtags): migrate to Vue 3 and script setup #57855

AndyScherzinger merged 3 commits into from
Jan 27, 2026
+1,497 −2,587

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 27, 2026 •
edited
Loading

Summary

  • Migrated app to Vue 3
  • Use script setup where feasible
  • Added missing doc blocks where it made sense

Checklist

@susnux susnux added this to the Nextcloud 34 milestone Jan 27, 2026
@susnux susnux requested a review from Antreesy January 27, 2026 16:41
@susnux susnux added 3. to review Waiting for reviews technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 27, 2026
@susnux susnux force-pushed the refactor/systemtags-vue branch 2 times, most recently from dfd7499 to e2f92b8 Compare January 27, 2026 17:24
@susnux susnux mentioned this pull request Jan 27, 2026
Open
32 tasks
@susnux
Copy link
Contributor Author

susnux commented Jan 27, 2026

/backport to stable33

@susnux susnux force-pushed the refactor/systemtags-vue branch from e2f92b8 to da8ef73 Compare January 27, 2026 19:41
@susnux susnux marked this pull request as ready for review January 27, 2026 20:14
@susnux susnux requested review from a team and skjnldsv as code owners January 27, 2026 20:14
@susnux susnux requested review from come-nc, leftybournes, nfebe, sorbaugh and szaimen and removed request for a team January 27, 2026 20:14
szaimen
szaimen approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

AndyScherzinger
AndyScherzinger approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

susnux added 3 commits January 27, 2026 23:52
@susnux
refactor(systemtags): migrate to Vue 3
50c849e 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(systemtags): remove duplicated event listener
16fbf5a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
b4b5986 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/systemtags-vue branch from da8ef73 to b4b5986 Compare January 27, 2026 22:52
@susnux
Copy link
Contributor Author

susnux commented Jan 27, 2026

(rebased because cypress is 99.9% unrelated and somehow broken with the current state - lets see after rebase)

@AndyScherzinger AndyScherzinger merged commit fa1f6e2 into master Jan 27, 2026
178 of 180 checks passed
@AndyScherzinger AndyScherzinger deleted the refactor/systemtags-vue branch January 27, 2026 23:22
@susnux
Copy link
Contributor Author

susnux commented Jan 27, 2026

(rebased because cypress is 99.9% unrelated and somehow broken with the current state - lets see after rebase)

Yes its like expected, somehow that state of cypress failed everytime but a simple new push (no code change) fixed cypress...

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 27, 2026

/backport to stable33

1 similar comment
@susnux
Copy link
Contributor Author

susnux commented Jan 28, 2026

/backport to stable33

@backportbot backportbot bot mentioned this pull request Jan 28, 2026
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@szaimen szaimen szaimen approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux @AndyScherzinger @szaimen