Skip to content

[stable32] fix(files_sharing): do not prevent share creation if password is enabled but not supported by the current share type#59262

Open
skjnldsv wants to merge 2 commits intostable32from
fix/sharing-password-checkbow
Open

[stable32] fix(files_sharing): do not prevent share creation if password is enabled but not supported by the current share type#59262
skjnldsv wants to merge 2 commits intostable32from
fix/sharing-password-checkbow

Conversation

@skjnldsv
Copy link
Copy Markdown
Member

@skjnldsv skjnldsv commented Mar 27, 2026 •
edited by susnux
Loading

Follow-up of #58226

the issue is this part by Fon: "Also block saving new shares when password protection is enabled but no password is entered, regardless of enforcement settings."
It does not take into account that many shares don't support password protection.
Considering we have backend protection, I would argue we should still let the request fire and react accordingly

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@skjnldsv
fix(files_sharing): do not prevent share creation if password is enab…
7aceb19 
…led but not supported by the current share type

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 32.0.7 milestone Mar 27, 2026
@skjnldsv skjnldsv self-assigned this Mar 27, 2026
@skjnldsv skjnldsv requested a review from a team as a code owner March 27, 2026 15:59
@skjnldsv skjnldsv requested review from nfebe and susnux and removed request for a team March 27, 2026 15:59
@skjnldsv skjnldsv added the bug label Mar 27, 2026
@skjnldsv skjnldsv requested a review from sorbaugh March 27, 2026 15:59
@github-actions github-actions bot changed the title fix(files_sharing): do not prevent share creation if password is enabled but not supported by the current share type [stable32] fix(files_sharing): do not prevent share creation if password is enabled but not supported by the current share type Mar 27, 2026
@skjnldsv
Copy link
Copy Markdown
Member Author

skjnldsv commented Mar 27, 2026

/backport! to stable33

@skjnldsv
Copy link
Copy Markdown
Member Author

skjnldsv commented Mar 27, 2026

/backport! to stable31

@backportbot backportbot bot mentioned this pull request Mar 27, 2026
Open
@backportbot backportbot bot mentioned this pull request Mar 27, 2026
Open
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 27, 2026

/backport! to master

@backportbot backportbot bot mentioned this pull request Mar 27, 2026
Open
@cristianscheid
Copy link
Copy Markdown
Contributor

cristianscheid commented Mar 27, 2026

/compile

@nextcloud-command
chore(assets): Recompile assets
eb657e9 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@cristianscheid cristianscheid cristianscheid approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: sharing regression

Projects

None yet

Milestone

Nextcloud 32.0.7

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @susnux @cristianscheid @artonge @nextcloud-command