Skip to content

fix(file-search): use default limit to search query if not provided on request body#59388

Merged
susnux merged 1 commit intomasterfrom
fix/noid/files-search-default-limit
Apr 2, 2026
Merged

fix(file-search): use default limit to search query if not provided on request body#59388
susnux merged 1 commit intomasterfrom
fix/noid/files-search-default-limit

Conversation

@cristianscheid
Copy link
Copy Markdown
Contributor

@cristianscheid cristianscheid commented Apr 1, 2026

  • Resolves: #

Summary

Sets a default limit for file search requests that don't include <d:limit> and <d:nresults> props. Without this, unlimited searches on large storages could exhaust PHP memory. Falls back to 100 results when no limit is specified.

Checklist

@cristianscheid cristianscheid force-pushed the fix/noid/files-search-default-limit branch 3 times, most recently from fa4562c to fdd44f6 Compare April 1, 2026 17:25
@cristianscheid cristianscheid added the 3. to review Waiting for reviews label Apr 1, 2026
@cristianscheid cristianscheid self-assigned this Apr 1, 2026
…n request body

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the fix/noid/files-search-default-limit branch from fdd44f6 to 3539476 Compare April 1, 2026 17:55
@cristianscheid cristianscheid marked this pull request as ready for review April 1, 2026 20:42
@cristianscheid cristianscheid requested a review from a team as a code owner April 1, 2026 20:42
@cristianscheid cristianscheid requested review from Altahrim, artonge, come-nc and salmart-dev and removed request for a team April 1, 2026 20:42
@artonge artonge added this to the Nextcloud 34 milestone Apr 2, 2026
@artonge artonge requested a review from susnux April 2, 2026 13:28
@cristianscheid
Copy link
Copy Markdown
Contributor Author

/backport to stable33

@cristianscheid
Copy link
Copy Markdown
Contributor Author

/backport to stable32

@susnux susnux merged commit c0cab68 into master Apr 2, 2026
222 of 233 checks passed
@susnux susnux deleted the fix/noid/files-search-default-limit branch April 2, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants