Skip to content

fix(chat-relay): localize system messages #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 8 commits into from
Jan 9, 2026
Merged

fix(chat-relay): localize system messages #16406

Antreesy merged 8 commits into from
Jan 9, 2026

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 24, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

2025-11-24_14h54_47

🚧 Tasks

  • API - missing $metaData[Message::METADATA_SILENT] for call_started system message
  • API - some additional messages to add via HPB?
  • Frontend - call_ended has too many backend information to copy mechanism on client
    • - discussed to throw and poll

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Nov 24, 2025
@Antreesy Antreesy self-assigned this Nov 24, 2025
DorraJaouad
DorraJaouad reviewed Nov 24, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/chat-relay-translations branch 2 times, most recently from 82edea4 to 53e5ba9 Compare December 22, 2025 17:27
@Antreesy Antreesy mentioned this pull request Dec 23, 2025
Merged
7 tasks
@Antreesy Antreesy force-pushed the fix/noid/chat-relay-translations branch from 53e5ba9 to 8e88ae6 Compare December 23, 2025 13:33
@Antreesy Antreesy changed the base branch from main to fix/noid/chat-relay-prereq December 23, 2025 13:33
@Antreesy Antreesy mentioned this pull request Dec 23, 2025
Open
8 tasks
@Antreesy Antreesy force-pushed the fix/noid/chat-relay-prereq branch from f53f57e to 129c4fb Compare January 5, 2026 15:15
Base automatically changed from fix/noid/chat-relay-prereq to main January 5, 2026 15:23
@Antreesy Antreesy force-pushed the fix/noid/chat-relay-translations branch from 8e88ae6 to 8171f9e Compare January 5, 2026 15:34
@Antreesy Antreesy marked this pull request as ready for review January 5, 2026 15:34
@Antreesy Antreesy requested a review from DorraJaouad January 5, 2026 15:34
@Antreesy Antreesy force-pushed the fix/noid/chat-relay-translations branch from 8171f9e to 8e5701e Compare January 8, 2026 15:51
@Antreesy Antreesy changed the title [wip] fix(chat-relay): localize system messages fix(chat-relay): localize system messages Jan 8, 2026
@Antreesy Antreesy requested a review from ShGKme January 8, 2026 15:52
nickvergessen
nickvergessen approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good otherwise after rebasing on main

@Antreesy
refactor: use constants in isHiddenSystemMessage
9ac631d 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
wip: prepare help functions and constants for localization
160de39 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
wip: translate 'call' system messages
dd6aacf 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
wip: translate 'moderator' system messages
fc62e9d 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
wip: translate 'history cleared' system messages
8aee121 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
wip: translate 'poll' system messages
0369ad0 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
wip: translate 'recording' system messages
455f8fc 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(useGetMessages): process translation on receiving from HPB
e83e4f2 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/chat-relay-translations branch from 8e5701e to e83e4f2 Compare January 9, 2026 11:13
@Antreesy Antreesy merged commit 6b8fd24 into main Jan 9, 2026
57 checks passed
@Antreesy Antreesy deleted the fix/noid/chat-relay-translations branch January 9, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v23.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @nickvergessen @DorraJaouad