Open
Conversation
Antreesy
reviewed
Mar 11, 2026
src/components/NewConversationDialog/NewConversationSetupPage.vue
Outdated
Show resolved
Hide resolved
src/components/ConversationSettings/ConversationSettingsDialog.vue
Outdated
Show resolved
Hide resolved
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
from
da45f4f to
c7c16bc
Compare
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
fix/noid/voice-rooms-frontend
branch
from
c7c16bc to
13f01e7
Compare
Antreesy
approved these changes
Mar 23, 2026
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Otherwise no objections, clean and simple. Let's wait for design feedback!
Two cents from me to discuss:
- when you're the first joined, shoud the waiting music be playing?
- when you're joining a 'voice room', should camera be enabled?
| } | ||
| }, | ||
|
|
||
| async joinCallAutomatically() { |
Contributor
There was a problem hiding this comment.
Maybe safer would be to pass a needed token? Both places it's used should have it
Suggested change
| async joinCallAutomatically() { | |
| async joinCallAutomatically(token) { |
DorraJaouad
commented
Mar 25, 2026
| console.info('Leaving call') | ||
| } | ||
|
|
||
| if (this.isVoiceRoom) { |
Contributor
Author
There was a problem hiding this comment.
should not be guest too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist