fix(deps): remove rubix' stemmer and its dependencies#1038
Open
ChristophWurst wants to merge 2 commits intomasterfrom
Open
fix(deps): remove rubix' stemmer and its dependencies#1038ChristophWurst wants to merge 2 commits intomasterfrom
ChristophWurst wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Member
Author
|
/backport to stable32 |
Collaborator
|
Please see my comment here #1037 (comment) as I'm not a big fan of modifying dependencies (although it work in that case). |
Member
|
Using scoper would be cleaner, I think, but for now I have created nextcloud/recognize#1414 which should fix this |
Collaborator
You mean using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
This app doesn't use stemming. There is no natural language processing, just IP addresses (numbers). Therefore, we don't need the conflicting libs.
@cyberpower678 @DerDreschner @marcelklehr please have a look