Skip to content

enh: display error popup when import preview fails #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 3 commits into from
Jan 7, 2025
Merged

enh: display error popup when import preview fails #1463

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06d2426
enh: display error popup when import preview fails
enjeck Nov 16, 2024
14e5566
enh: Show error instead of loading icon when import fails
enjeck Nov 27, 2024
64116a4
enh: remove duplicated code and toast
enjeck Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 41 additions & 56 deletions src/modules/modals/Import.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,17 @@

<!-- show loading -->
<div v-if="loading && !waitForReload">
<NcEmptyContent :name="t('tables', 'Importing data from ') + importFileName" :description="t('tables', 'This might take a while...')">
<template #icon>
<NcIconTimerSand />
</template>
</NcEmptyContent>
<div v-if="!importFailed">
<NcEmptyContent :name="t('tables', 'Importing data from ') + importFileName"
:description="t('tables', 'This might take a while...')">
<template #icon>
<NcIconTimerSand />
</template>
</NcEmptyContent>
</div>
<div v-else>
<NcEmptyContent :name="t('tables', 'Failed')" :description="errorMessage" />
</div>
</div>

<div v-if="waitForReload">
Expand All @@ -110,7 +116,7 @@

<script>
import { NcDialog, NcButton, NcCheckboxRadioSwitch, NcEmptyContent, NcLoadingIcon } from '@nextcloud/vue'
import { getFilePickerBuilder, FilePickerType, showError, showWarning } from '@nextcloud/dialogs'
import { getFilePickerBuilder, FilePickerType, showWarning } from '@nextcloud/dialogs'
import RowFormWrapper from '../../shared/components/ncTable/partials/rowTypePartials/RowFormWrapper.vue'
import permissionsMixin from '../../shared/components/ncTable/mixins/permissionsMixin.js'
import IconFolder from 'vue-material-design-icons/Folder.vue'
Expand Down Expand Up @@ -164,6 +170,7 @@ export default {
createMissingColumns: true,
pathError: false,
loading: false,
importFailed: false,
result: null,
preview: null,
columnsConfig: [],
Expand All @@ -177,6 +184,7 @@ export default {
'application/vnd.oasis.opendocument.spreadsheet',
],
selectedUploadFile: null,
errorMessage: t('tables', 'Could not import data due to unknown errors.'),
}
},

Expand Down Expand Up @@ -281,21 +289,14 @@ export default {
if (res.status === 200) {
this.preview = res.data
this.loading = false
} else if (res.status === 401) {
console.debug('error while importing', res)
showError(t('tables', 'Could not import, not authorized. Are you logged in?'))
} else if (res.status === 403) {
console.debug('error while importing', res)
showError(t('tables', 'Could not import, missing needed permission.'))
} else if (res.status === 404) {
console.debug('error while importing', res)
showError(t('tables', 'Could not import, needed resources were not found.'))
} else {
showError(t('tables', 'Could not import data due to unknown errors.'))
console.debug('error while importing', res)
this.handleResponse(res, null)
this.importFailed = true
}
} catch (e) {
this.errorMessage = t('tables', 'Could not import data due to unknown errors.')
console.error(e)
this.importFailed = true
return false
}
},
Expand All @@ -315,21 +316,14 @@ export default {
if (res.status === 200) {
this.preview = res.data
this.loading = false
} else if (res.status === 401) {
console.debug('error while importing', res)
showError(t('tables', 'Could not import, not authorized. Are you logged in?'))
} else if (res.status === 403) {
console.debug('error while importing', res)
showError(t('tables', 'Could not import, missing needed permission.'))
} else if (res.status === 404) {
console.debug('error while importing', res)
showError(t('tables', 'Could not import, needed resources were not found.'))
} else {
showError(t('tables', 'Could not import data due to unknown errors.'))
console.debug('error while importing', res)
this.handleResponse(res, null)
this.importFailed = true
}
} catch (e) {
this.errorMessage = t('tables', 'Could not import data due to unknown errors.')
console.error(e)
this.importFailed = true
return false
}
},
Expand Down Expand Up @@ -389,22 +383,10 @@ export default {
this.result = res.data
} else {
console.debug('error while importing', res)
showError(t('tables', res.data?.message || 'Could not import data due to unknown errors.'))
this.errorMessage = t('tables', res.data?.message || 'Could not import data due to unknown errors.')
}
} catch (e) {
if (e.response?.status === 401) {
console.debug('error while importing', e)
showError(t('tables', 'Could not import, not authorized. Are you logged in?'))
} else if (e.response?.status === 403) {
console.debug('error while importing', e)
showError(t('tables', 'Could not import, missing needed permission.'))
} else if (e.response?.status === 404) {
console.debug('error while importing', e)
showError(t('tables', 'Could not import, needed resources were not found.'))
} else {
console.debug('error while importing', e)
showError(t('tables', e.response.data?.message || 'Could not import data due to unknown errors.'))
}
this.handleResponse(e.response, e)
}
this.loading = false
},
Expand All @@ -427,22 +409,10 @@ export default {
this.result = res.data
} else {
console.debug('error while importing', res)
showError(t('tables', res.data?.message || 'Could not import data due to unknown errors.'))
this.errorMessage = t('tables', res.data?.message || 'Could not import data due to unknown errors.')
}
} catch (e) {
if (e.response?.status === 401) {
console.debug('error while importing', e)
showError(t('tables', 'Could not import, not authorized. Are you logged in?'))
} else if (e.response?.status === 403) {
console.debug('error while importing', e)
showError(t('tables', 'Could not import, missing needed permission.'))
} else if (e.response?.status === 404) {
console.debug('error while importing', e)
showError(t('tables', 'Could not import, needed resources were not found.'))
} else {
console.debug('error while importing', e)
showError(t('tables', e.response?.data?.message || 'Could not import data due to unknown errors.'))
}
this.handleResponse(e.response, e)
}
this.loading = false
},
Expand Down Expand Up @@ -488,6 +458,21 @@ export default {
onUpdateColumnsConfig(event) {
this.columnsConfig = event
},
handleResponse(res, e) {
if (res?.status === 401) {
console.debug('error while importing', e || res)
this.errorMessage = t('tables', 'Could not import, not authorized. Are you logged in?')
} else if (res?.status === 403) {
console.debug('error while importing', e || res)
this.errorMessage = t('tables', 'Could not import, missing needed permission.')
} else if (res?.status === 404) {
console.debug('error while importing', e || res)
this.errorMessage = t('tables', 'Could not import, needed resources were not found.')
} else {
console.debug('error while importing', e || res)
this.errorMessage = t('tables', e?.response?.data?.message || 'Could not import data due to unknown errors.')
}
},
},

}
Expand Down