Adding bubbles support #5554

arlexTech · 2025-11-14T12:20:13Z

🖼️ Screenshots

General settings	Conversation Info

VID_20251114124529.mp4

Record_2025-11-14-12-44-40.mp4

🚧 TODO

Bubble Works
Activating bubbles in settings
Activating or not bubbles for each conversation
Use Conversation Avatar for bubble icon
Multiple bubbles for multiple conversations
Embedded view
Create a bubble notification upon received message

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed
🔖 Capability is checked or not needed
🔙 Backport requests are created or not needed: /backport to stable-xx.x
📅 Milestone is set
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

+
+                // Use the same notification ID calculation as NotificationWorker
+                // Show notification with bubble
+                notificationManager.notify(notificationId, notification)


mahibi · 2025-11-17T08:54:43Z

thank you @arlexTech
we will review soon!

mahibi

Thank you @arlexTech ! 👍
The bubbles itself work for me, however there are some things that must be changed:

Don't show conversation list and modify back button handling

I strongly suggest to not open the conversation list when pressing back button in bubbled mode.
So the bubbled view should not show the conversation list at all but only single conversations. Otherwise i'm concerned of bugs when having multiple instance of the ConversationListActivity.

For the back button in bubbled mode, either:

just close the bubble (This is how Telegram does it)
or replace the back button with a the talk icon which will open the app in normal mode and the conversation list is shown (This is how signal does it and it'S also my preferred solution)

Avoid multiple instance of ChatActivity for same conversation

Also, we should make sure that there are not multiple instances of ChatActivity for the same conversation.

Right now, the PR has a bug that multiple instances are shown when "open in app" is used.
https://developer.android.com/develop/ui/views/notifications/bubbles#launching-activities

But also we should not allow to have 2 instances for the same conversation when one is opened in normal mode and one in bubble mode.
This is very important to avoid bugs in the chat repository (OfflineFirstChatRepository)!

Signal solved it this way: Whenever there is a bubble for a chat and the chat is also opened in the normal mode, the bubble closes.
We should solve it the same way and try to use only one instance of ChatActivity for a conversation.

app/src/main/java/com/nextcloud/talk/chat/BubbleActivity.kt

app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt

mahibi · 2025-11-20T15:13:06Z

app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt

+        // Use a consistent ID based on the room token to avoid duplicate bubbles
        val systemNotificationId: Int =
-            activeStatusBarNotification?.id ?: calculateCRC32(System.currentTimeMillis().toString()).toInt()
+            activeStatusBarNotification?.id ?: NotificationUtils.calculateCRC32(pushMessage.id!!).toInt()


i am not 100% if using the room token could cause unwanted side effects. will have to think about and test when i have better internet connection ;)

mahibi · 2025-11-20T15:29:32Z

@rapterjet2004 @sowjanyakch please also do a deep review. E.g. specially check if former notification handling is affected by the changes.

app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt

arlexTech · 2025-11-22T19:29:59Z

I'll work on it this week (don't mind the review request i miss clicked)

mahibi · 2025-11-24T08:30:17Z

I'll work on it this week (don't mind the review request i miss clicked)

Sure, thanks. Let us know if there are any questions or help is needed!

github-actions · 2025-11-29T02:21:57Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

arlexTech · 2025-12-06T16:35:48Z

For the back button in bubbled mode I replaced it by the talk icon in bubble mode which open the app in normal mode on the conversation list

as onBackPressed is deprecated we want to avoid it and use onBackPressedDispatcher

fixed

multiple instances of the app are opened when "open is app" is used. https://developer.android.com/develop/ui/views/notifications/bubbles#launching-activities

should be fixed, I couldn't open multiple anymore

please try to extract the above code into a method

done

why is this removed?

because it was preventing bubbles to show up but it should be fixed now

I wanted the handleOnBackPressed function to minimize the bubble but I tried for hours and never managed to make it work correctly, if anyone has an idea of how to do it, I'm open to try anything at this point

Tell me if i can do anything more to merge it

arlexTech · 2025-12-06T16:35:59Z

But also we should not allow to have 2 instances for the same conversation when one is opened in normal mode and one in bubble mode.
This is very important to avoid bugs in the chat repository (OfflineFirstChatRepository)!
Signal solved it this way: Whenever there is a bubble for a chat and the chat is also opened in the normal mode, the bubble closes.
We should solve it the same way and try to use only one instance of ChatActivity for a conversation.

I didn't see this part, I wonder how Messenger deal with that because it can have the bubble and the chat open at the same time

mahibi

Thanks to implement the suggestions @arlexTech 👍 We appreciate your efforts!

I commented on some things that must be changed.

There were changes on master in NotificationWorker that conflict with your branch. Could you resolve it?

Please also see the codacy warnings at
https://app.codacy.com/gh/nextcloud/talk-android/pull-requests/5554/issues

and sign your commits like described in
https://github.com/nextcloud/talk-android/pull/5554/checks?check_run_id=57331453438

If you need any help or nextcloud employees should take over, just let us know.

app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

sowjanyakch

Thank you for PR @arlexTech

The inbuilt emoji picker does not appear when tapping the emoji icon in the bubble notification chat view.

arlexTech · 2025-12-19T12:54:56Z

Thank you for your feedback, i try to fix all of this and if I'm hard stuck I'll ask for help

Signed-off-by: alex <[email protected]>

…when enabled Signed-off-by: alex <[email protected]>

Signed-off-by: alex <[email protected]>

arlexTech · 2026-01-01T19:25:17Z

I think I fixed everything you said but the emoji picker, for the emoji picker I tried but didn't managed to make it work, it simply never shows up

mahibi · 2026-01-08T14:47:48Z

@arlexTech i'm currently taking a look and modify some things. Is it okay for you if i push to the branch?

arlexTech · 2026-01-08T15:06:37Z

@arlexTech i'm currently taking a look and modify some things. Is it okay for you if i push to the branch?

Yes no problem

Signed-off-by: Marcel Hibbe <[email protected]>

instead to use KEY_NOTIFICATION_RESTRICT_DELETION, always check if notification is actually bubbled in cancelNotification Without this commit, bubbled notifications would remain open when the chat was opened in normal mode. With this commit, bubbled notifications will be removed when opening the chat in normal mode. Signed-off-by: Marcel Hibbe <[email protected]>

…" is chosen for a conversation before this commit, only systemAllowsAllConversations was checked. This was not enough but also system wide enabling of bubbles must be checked + minor refactoring Signed-off-by: Marcel Hibbe <[email protected]>

mahibi · 2026-01-08T18:07:30Z

I took a closer look and changed/fixed some things. Please see the commit messages and let me know if you have questions/comments.

Could you please sync the fork and rebase on master to have the newest upstream changes?

I think we are getting there to merge it soon.

I think I fixed everything you said but the emoji picker, for the emoji picker I tried but didn't managed to make it work, it simply never shows up

Did not have a look but it's not a blocker to merge. I would like to replace the emojipicker (#2735), maybe this would even fix it.

@sowjanyakch and @rapterjet2004 could you please review/test this PR a lot? At best also with different android versions. With bubbles enabled and also disabled (so, normal notifications).

@arlexTech if you are willing to (so not a blocker for merging), it would be great if you could move some bubbles logic out of the ChatActivity, e.g. to NotificationsUtils. For example createConversationBubble..

mahibi · 2026-01-08T18:10:16Z

Regarding:

Could you please sync the fork and rebase on master to have the newest upstream changes?

@arlexTech let me know if you would like to have rights to the original repo. So you could create branches inside it if you would like to further contribute in the future and reviewing gets easier for nc devs..

mahibi · 2026-01-08T18:12:52Z

app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt

-            activeStatusBarNotification?.id ?: calculateCRC32(System.currentTimeMillis().toString()).toInt()
-
-        if (TYPE_CHAT == pushMessage.type || TYPE_REMINDER == pushMessage.type) {
+        // Use a consistent ID based on the room token to avoid duplicate bubbles


please remove the last comment line as it's outdated

AndyScherzinger requested review from mahibi, rapterjet2004 and sowjanyakch November 14, 2025 12:56

AndyScherzinger added enhancement New feature or request 3. to review Waiting for reviews labels Nov 14, 2025

github-advanced-security bot found potential problems Nov 14, 2025

View reviewed changes

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Nov 14, 2025

View reviewed changes

mahibi requested changes Nov 20, 2025

View reviewed changes

mahibi reviewed Nov 20, 2025

View reviewed changes

app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt Outdated Show resolved Hide resolved

arlexTech requested a review from mahibi November 22, 2025 19:27

github-actions bot added the feedback-requested label Nov 29, 2025

mahibi requested changes Dec 15, 2025

View reviewed changes

app/src/main/java/com/nextcloud/talk/jobs/NotificationWorker.kt Outdated Show resolved Hide resolved

app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt Show resolved Hide resolved

sowjanyakch requested changes Dec 16, 2025

View reviewed changes

arlexTech added 9 commits December 28, 2025 15:18

Adding bubbles support

18a7a2f

Signed-off-by: alex <[email protected]>

fix ktlintCheck detekt testGplayDebugUnitTest

57c2d7f

Signed-off-by: alex <[email protected]>

remove deprecated onBackPressed and extracted code in function

0053b5b

Signed-off-by: alex <[email protected]>

prevent second app instance and adding talk icon button in bubble mode

734a700

Signed-off-by: alex <[email protected]>

fix potential issue with room token

3cc598e

Signed-off-by: alex <[email protected]>

fix getLargeIcon preventing bubble notification

eaf4731

Signed-off-by: alex <[email protected]>

bubbles off by default and lead to android bubble settings if needed …

63f0818

…when enabled Signed-off-by: alex <[email protected]>

codacy warnings

7c463cb

Signed-off-by: alex <[email protected]>

systemNotificationId fix

4e23c56

Signed-off-by: alex <[email protected]>

Fix 2 bubbles

d11c761

Signed-off-by: alex <[email protected]>

arlexTech force-pushed the feature/bubble-conversations branch from b33937a to d11c761 Compare January 1, 2026 19:22

Merge branch 'master' into feature/bubble-conversations

0578f62

mahibi added 3 commits January 8, 2026 18:53

fix user provider usage

605af97

Signed-off-by: Marcel Hibbe <[email protected]>

mahibi force-pushed the feature/bubble-conversations branch from 3e25a68 to 0341869 Compare January 8, 2026 17:55

mahibi reviewed Jan 8, 2026

View reviewed changes

Merge branch 'nextcloud:master' into feature/bubble-conversations

39bb469

Uh oh!

Adding bubbles support #5554

Are you sure you want to change the base?

Adding bubbles support #5554

Uh oh!

Conversation

arlexTech commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🖼️ Screenshots

🚧 TODO

🏁 Checklist

Uh oh!

Uh oh!

Check failure

mahibi commented Nov 17, 2025

Uh oh!

mahibi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Don't show conversation list and modify back button handling

Avoid multiple instance of ChatActivity for same conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mahibi Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

mahibi commented Nov 20, 2025

Uh oh!

Uh oh!

arlexTech commented Nov 22, 2025

Uh oh!

mahibi commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 29, 2025

Uh oh!

arlexTech commented Dec 6, 2025 • edited by mahibi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arlexTech commented Dec 6, 2025

Uh oh!

mahibi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sowjanyakch left a comment

Choose a reason for hiding this comment

Uh oh!

arlexTech commented Dec 19, 2025

Uh oh!

arlexTech commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mahibi commented Jan 8, 2026

Uh oh!

arlexTech commented Jan 8, 2026

Uh oh!

mahibi commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mahibi commented Jan 8, 2026

Uh oh!

mahibi Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arlexTech commented Nov 14, 2025 •

edited

Loading

mahibi left a comment •

edited

Loading

arlexTech commented Dec 6, 2025 •

edited by mahibi

Loading

mahibi left a comment •

edited

Loading

arlexTech commented Jan 1, 2026 •

edited

Loading

mahibi commented Jan 8, 2026 •

edited

Loading