Skip to content

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jan 16, 2026

Given that I am used to "thicker wave-forms" on other messengers, I played around with the values, see below.

I tend to prefer 3-fine

🖼️ Screenshots

🏚️ Before (2) 🏡 After (3) 🏡 After (3-fine optimized) 🏡 After (4) 🏡 After (4-fine optimized)
before width3 3fine after_new 4fine

🚧 TODO

  • get design feedback

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Jan 16, 2026
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews labels Jan 16, 2026
@AndyScherzinger AndyScherzinger marked this pull request as ready for review January 16, 2026 16:38
@AndyScherzinger AndyScherzinger force-pushed the style/noid/waveform branch 2 times, most recently from 4043947 to 99d1ab2 Compare January 16, 2026 17:01
@AndyScherzinger AndyScherzinger changed the title Make wave form thicker 2->4 Make wave form thicker Jan 16, 2026
@AndyScherzinger AndyScherzinger force-pushed the style/noid/waveform branch 2 times, most recently from 6287419 to ca0aff1 Compare January 19, 2026 07:39
@nickvergessen
Copy link
Member

I prefer 3-fine

@AndyScherzinger AndyScherzinger force-pushed the style/noid/waveform branch 2 times, most recently from 17bf391 to d8e0f93 Compare January 19, 2026 08:45
@mahibi
Copy link
Collaborator

mahibi commented Jan 19, 2026

3-fine is fine for me ;)

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed 3-fine looks the best to me too 👍🏽

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5723.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit dd141af into master Jan 19, 2026
16 of 17 checks passed
@AndyScherzinger AndyScherzinger deleted the style/noid/waveform branch January 19, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants