Skip to content

Conversation

@kikoso
Copy link
Contributor

@kikoso kikoso commented Jan 25, 2026

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
N/A (See video below)
N/A https://github.com/user-attachments/assets/9c9efe16-730d-45db-b872-ea97996c7cbd

🚧 TODO

  • Implement SwipeToCloseLayout for vertical gesture detection
  • Integrate SwipeToCloseLayout into FullScreenImageActivity
  • Integrate SwipeToCloseLayout into FullScreenMediaActivity

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@kikoso kikoso force-pushed the feat/5609-swipe-to-close-media branch from 4192e90 to 2ec710e Compare January 25, 2026 13:23
…#5609)

Signed-off-by: Enrique López ManΜƒas <eenriquelopez@gmail.com>
@kikoso kikoso force-pushed the feat/5609-swipe-to-close-media branch from 2ec710e to c71d816 Compare January 25, 2026 13:26
@kikoso
Copy link
Contributor Author

kikoso commented Jan 25, 2026

@AndyScherzinger , @nickvergessen , I have added this PR fixing #5609 . #5398 would be a natural next candidate to get fixed, I might tackle it in a different PR.

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Jan 25, 2026
@kikoso
Copy link
Contributor Author

kikoso commented Jan 26, 2026

@AndyScherzinger : the new checks are failing due to:

Kotlin version 2.3.0 is too recent. CodeQL currently supports versions below 2.2.30

CodeQL expects to support Kotlin 2.3.0 in February.

@mahibi
Copy link
Collaborator

mahibi commented Jan 27, 2026

Thank you @kikoso
works fine πŸ‘

Could you please add the copyright header

/*

  • Nextcloud Talk - Android Client
  • SPDX-FileCopyrightText: yourname...
  • SPDX-License-Identifier: GPL-3.0-or-later
    */

to SwipeToCloseLayout and add yourself to the other headers of the files you modified (this will fix the REUSE warning)?
For the other failing checks: it's unrelated to the PR so we are aware and need to fix them. This PR can be merged with red checks.

Signed-off-by: Enrique LΓ³pez MaΓ±as <eenriquelopez@gmail.com>
@kikoso
Copy link
Contributor Author

kikoso commented Jan 27, 2026

@mahibi , done. You could consider automation tools like addlicense to automatically update them (or verify if they have been updated).

@mahibi mahibi merged commit 8bd212f into nextcloud:master Jan 27, 2026
8 of 15 checks passed
@mahibi mahibi added this to the 23.1.0 milestone Jan 27, 2026
@mahibi
Copy link
Collaborator

mahibi commented Jan 27, 2026

/backport to stable-23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to close photos and videos by swipe gesture

3 participants