fix(talk): title bar controls color is not inline with theming#1657
Merged
fix(talk): title bar controls color is not inline with theming#1657
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Antreesy
approved these changes
Feb 6, 2026
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Otherwise nice. Need to check if it can be applied to notifications app red badge dot
Comment on lines
+135
to
+136
| export function getTitleBarSymbolColor(backgroundColor: string = BUILD_CONFIG.backgroundColor): string { | ||
| return invertTextColor(backgroundColor) ? '#000000' : '#FFFFFF' |
Contributor
There was a problem hiding this comment.
I know scoped functions will be hoisted, but it's weird to read 👀
Contributor
Author
There was a problem hiding this comment.
Just to keep them scoped because they are only used for this specific utility (for now) and their names are taken from the server.
Until we create x100/x1000 application Windows per second, this optimisation is a micro-optimisation.
Contributor
Author
At the moment we don't have it in the Talk Desktop anyway... But yeah, it would be good to test on the server. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
#FFFFFF🖼️ Screenshots