fix(talk): increase visibility of new update availability in the main menu#1663
Merged
fix(talk): increase visibility of new update availability in the main menu#1663
Conversation
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
UI looks good, can't judge the code fully
|
|
||
| <template v-if="updateAvailable"> | ||
| <NcActionLink | ||
| href="https://github.com/nextcloud/talk-desktop/releases/latest" |
Member
There was a problem hiding this comment.
Suggested change
| href="https://github.com/nextcloud/talk-desktop/releases/latest" | |
| href="https://github.com/nextcloud-releases/talk-desktop/releases/latest" |
Too bad pre-release is not working the same way
Contributor
Author
There was a problem hiding this comment.
This is out of scope for this PR
Antreesy
approved these changes
Feb 18, 2026
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Looks good, dot on cloud is still a bit distant, but overall fine.
With branded colors, there could be an issue like nextcloud/notifications#1340 and should be considered for future
Antreesy
approved these changes
Feb 18, 2026
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/update-notification-design
branch
from
d06ad0e to
2be2ad0
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Updatemenu item to show that is new in the menu🖼️ Screenshots