Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

No description provided.

@max-nextcloud max-nextcloud force-pushed the chore/split-source-view branch from 8d2577a to 0b8c9b5 Compare December 13, 2025 07:57
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@max-nextcloud max-nextcloud force-pushed the chore/split-source-view branch from 0b8c9b5 to e169a03 Compare December 15, 2025 15:34
@max-nextcloud max-nextcloud marked this pull request as ready for review December 15, 2025 17:26
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring! Out of curiosity, why did you do it? Is it part of a bigger plan? Or just something that caught your eye and cried for a component split? 😊

Code changes look good to me. I didn't test but guess you did. I have two small comments/questions.

@max-nextcloud
Copy link
Collaborator Author

Thanks for the refactoring! Out of curiosity, why did you do it? Is it part of a bigger plan? Or just something that caught your eye and cried for a component split? 😊

I'm looking into a way to make the ViewerComponent create a separate vue instance from the viewer itself. This should do away with some warnings about attrs and listeners being readonly and so on.

grafik

So this is a first step in that direction by making the ViewerComponent less complex.

@max-nextcloud max-nextcloud force-pushed the chore/split-source-view branch from e169a03 to bdc845b Compare January 12, 2026 16:20
@max-nextcloud
Copy link
Collaborator Author

Versions playwright spec is known to fail due to nextcloud/viewer#3046

@max-nextcloud max-nextcloud merged commit 48b14f3 into main Jan 12, 2026
63 of 64 checks passed
@max-nextcloud max-nextcloud deleted the chore/split-source-view branch January 12, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants