Conversation
…d HTTP status validation - Validate HTTP status code - Clear libxml error state in a finally block to prevent leaking into subsequent parsing - Add CURLOPT_CONNECTTIMEOUT (10s) and CURLOPT_TIMEOUT (30s) to prevent indefinite hangs - Retry once with 1s backoff on transient failures Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
…onse Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
added
enhancement
3. to review
robustness 💪
skjnldsv
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the weekend apparently there was an Updater Server event causing unexpected responses. This attempts to make the initial checks a bit more robust and informative (rather than just indicating "No update available").
Changes:
P.S. We should consider maybe adjusting the updater_server API contract to use 204, but it's not a huge deal at the moment.