feat: Initiate login to IdP via POST #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hweihwang
force-pushed
the
feat/post-login
branch
from
ad1a2da to
b2c8e3d
Compare
blizzz
reviewed
Jul 2, 2024
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Have not tested yet, looks good on first sight, just two small nitpicks (and knowing about the open questions).
hweihwang
force-pushed
the
feat/post-login
branch
2 times, most recently
from
7551b07 to
e8c669b
Compare
blizzz
requested changes
Jul 5, 2024
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Please check the post if-branch in login().
When modifying this locally and testing with keycloak I receive "We are sorry... Invalid Request". But it could be my Keycloak config needs adjustment, if it supports that.
blizzz
reviewed
Jul 9, 2024
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Looks good and works 👍
Any luck with shibboleth integration tests yet?
hweihwang
force-pushed
the
feat/post-login
branch
from
5fd6a9e to
93b9a22
Compare
blizzz
approved these changes
Oct 2, 2024
Member
|
@hweihwang since it is all done, can you do a rebase and perhaps add an |
hweihwang
force-pushed
the
feat/post-login
branch
6 times, most recently
from
15c2005 to
530c132
Compare
blizzz
reviewed
May 6, 2025
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
one question and one suggestion
Signed-off-by: Hoang Pham <[email protected]>
blizzz
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.