fix(Controller): make redirectUrl optional #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that calling it does not break when doing it manually and the redirect parameter is lost Signed-off-by: Arthur Schiwon <[email protected]>
Member
Author
|
Failing tests are PHP 8.4 related and due to the SAML lib that uses deprecated implicit nullable types. I.e. not relevant to this fix. |
Member
Author
❓ I don't think I am getting it. Slim Pickens does the right thing and carries the bomb to hell? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so that calling it does not break when doing it manually and the redirect parameter is lost.
The empty string is also the fallback if it the redirect target was not specified in normal operations.