refactor: Apply code best practices PHP8+ #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
force-pushed
the
bestPracticesPHP8
branch
4 times, most recently
from
ef27305 to
bc80c1c
Compare
Member
Author
|
Failure to be handled upstream: https://github.com/SAML-Toolkits/php-saml/pull/600/files |
solracsf
added
2. developing
3. to review
refactor
and removed
3. to review
2. developing
labels
Signed-off-by: Git'Fellow <[email protected]>
Signed-off-by: Git'Fellow <[email protected]>
blizzz
force-pushed
the
bestPracticesPHP8
branch
from
3e2eef7 to
27d09bb
Compare
Member
|
@solracsf Thanks! php-saml is patched now here until there is a new release of it. I rebased, let the green ticks come 🍀 |
blizzz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes, only code updates.