Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Dec 3, 2024

chaining .success() and .fail() was not working anymore, and jQuery is to be deprecated anyway. A step thereto! Also clears metadata step after an unsuccessful save to not be misleading.

Fixes

TypeError: $.ajax(...).fail(...).success is not a function

Uncaught TypeError: $.ajax(...).fail(...).success is not a function
    testMetaData https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:139
    success https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:155
    onload https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:96
    updateProvider https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:94
    setSamlConfigValue https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:166
    ve https://cloud.example.com/dist/core-main.js?v=4456f07a-2:1
    i https://cloud.example.com/dist/core-main.js?v=4456f07a-2:1
    k https://cloud.example.com/dist/core-main.js?v=4456f07a-2:1
    promise callback*requirePasswordConfirmation https://cloud.example.com/dist/core-main.js?v=4456f07a-2:1
    setSamlConfigValue https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:147
    <anonymous> https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:322
    u https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    d https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    setTimeout handler*74692/</Deferred/then/o/< https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    l https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    add https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    then https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    Deferred https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    then https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    <anonymous> https://cloud.example.com/apps/user_saml/js/admin.js?v=4456f07a-2:320
    dispatch https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
    handle https://cloud.example.com/dist/core-common.js?v=4456f07a-2:1
admin.js:139:7

chaining .success() and .fail() was not working anymore, and jQuery is to
be deprecated anyway. A step thereto! Also clears metadata step after
an unsuccessful save to not be misleading.

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz merged commit 0587c34 into master Dec 3, 2024
45 checks passed
@blizzz blizzz deleted the fix/noid/metadata-ajax-error branch December 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants